Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bumping to versions which are not Long Term Support (LTS) version #2247

Open
dmabamboo opened this issue Jul 23, 2018 · 20 comments
Open
Labels
F: configuration-file F: dependency-ignores Allow excluding certain versions F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. Keep Exempt this from being marked by stalebot L: docker Docker containers T: feature-request Requests for new features T: new-ecosystem Requests for new ecosystems/languages

Comments

@dmabamboo
Copy link

Hi,

Is there a way to avoid dependabot offering non-LTS versions of Node.JS? We don't want to run any non-LTS versions but don't want to miss out on updates to the LTS version.

Regards,
Daniel

@greysteil
Copy link
Contributor

Hey Daniel,

Interesting question. Is there a particular PR that's getting it wrong? If you link to that (you can email me on support@dependabot.com) then I'll have a think about specially how Dependabot could do better there.

@dmabamboo
Copy link
Author

Sorry @greysteil I didn't follow it up, sent you an email as requested.
Regards,
Dan

@lucas42
Copy link

lucas42 commented Oct 23, 2019

Hi,
   I was wondering whether you came to any conclusions from your email discussion on this?
I'm interested in the same thing, but didn't want to raise something new if it's already been looked into.

Cheers,
       Luke

@rebelagentm
Copy link
Contributor

@lucas42 Grey is no longer working on Dependabot (he's moved to security in general at GitHub), but I looked back through that support conversation, and I believe this was the conclusion:

  • It would be tricky from a Dependabot standpoint to have something specific to Node and LTS, but Grey didn't shut the door completely to the possibility.

That being said, the team is currently pretty swamped scaling Dependabot for GitHub, so it would be some time before we could get to looking into this. Since there is interest in this, I'm going to re-open this issue so we have it on our list.

@rebelagentm rebelagentm reopened this Oct 24, 2019
@lucas42
Copy link

lucas42 commented Oct 24, 2019

Thanks!
I'm only using dependabot for some personal projects to begin with, so happy to upgrade to the latest and greatest of each release.

But if we were to roll it out across various team at work, this would be a must-have feature.

Cheers

@rebelagentm
Copy link
Contributor

Thanks for the feedback, @lucas42! We'll keep that in mind once we're able to turn our attention back to working on enhancements like this.

@infin8x infin8x transferred this issue from dependabot/feedback Jun 29, 2020
@infin8x infin8x added L: javascript:npm npm packages via npm T: feature-request Requests for new features F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. T: new-ecosystem Requests for new ecosystems/languages labels Jul 2, 2020
@oittaa
Copy link

oittaa commented Mar 8, 2021

Just encountered this issue when dependabot tried to update node from 14.16.0-alpine3.13 to 15.11.0-alpine3.13

oittaa/firebase-docker#1

@TanguyChiffoleau
Copy link

An implementation of such a feature would be so great

domenic added a commit to whatwg/participate.whatwg.org that referenced this issue May 3, 2021
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue May 3, 2021
@asciimike
Copy link
Contributor

Can you use ignore conditions to ignore odd versions, e.g.:

version: 2
updates:
  - package-ecosystem: "docker"
    directory: "/"
    schedule:
      interval: "daily"
    ignore:
      - dependency-name: "node"
        versions: ["15.x", "17.x", ...]

I recognize that it's not automatic (e.g. we can't automatically ignore odd versions), but it only requires an update every six months (at most, you could even drop in the first few now...), which feels better than always closing the PR.

@domenic
Copy link

domenic commented Aug 2, 2021

That doesn't work for the six month period (like the one we're in now with Node v16) where an even version is "current" but not yet promoted to "active LTS".

domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Aug 2, 2021
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Aug 2, 2021
domenic added a commit to whatwg/build.whatwg.org that referenced this issue Aug 2, 2021
domenic added a commit to whatwg/build.whatwg.org that referenced this issue Aug 2, 2021
@asciimike
Copy link
Contributor

@domenic thanks for following up; is there a way to know if a version is LTS purely by looking at it, or would we have to add code to look at https://nodejs.org/en/about/releases/ and add six months (or manually update it every several years)?

Seems like that the ignore would technically work, it would just have to be manually removed after the six month period.

domenic added a commit to whatwg/build.whatwg.org that referenced this issue Aug 2, 2023
Note that this also upgrades our Debian version!

Closes #82. See dependabot/dependabot-core#2247 for why this is necessary.
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Aug 2, 2023
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Aug 2, 2023
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Sep 2, 2023
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Sep 2, 2023
domenic added a commit to whatwg/build.whatwg.org that referenced this issue Dec 3, 2023
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Dec 3, 2023
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Dec 3, 2023
@jonjanego jonjanego added the Keep Exempt this from being marked by stalebot label May 2, 2024
domenic added a commit to whatwg/build.whatwg.org that referenced this issue May 2, 2024
domenic added a commit to whatwg/build.whatwg.org that referenced this issue May 2, 2024
domenic added a commit to whatwg/build.whatwg.org that referenced this issue May 2, 2024
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue May 7, 2024
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue May 7, 2024
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue May 7, 2024
domenic added a commit to whatwg/build.whatwg.org that referenced this issue Jun 3, 2024
domenic added a commit to whatwg/build.whatwg.org that referenced this issue Jun 3, 2024
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Jun 3, 2024
domenic added a commit to whatwg/participate.whatwg.org that referenced this issue Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: configuration-file F: dependency-ignores Allow excluding certain versions F: language-support Issues specific to a particular language or ecosystem; may be paired with an L: label. Keep Exempt this from being marked by stalebot L: docker Docker containers T: feature-request Requests for new features T: new-ecosystem Requests for new ecosystems/languages
Projects
None yet
Development

No branches or pull requests