Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go modules prerelease #10022

Merged

Conversation

stefanvanburen
Copy link
Contributor

@stefanvanburen stefanvanburen commented Jun 17, 2024

What are you trying to accomplish?

The @prerelease component should include everything after the -, not only the initial split. Otherwise, comparing prereleases with multiple - does not work.

Fixes #10020.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@stefanvanburen stefanvanburen requested a review from a team as a code owner June 17, 2024 14:28
@github-actions github-actions bot added the L: go:modules Golang modules label Jun 17, 2024
The `@prerelease` component should include everything after the `-`, not
only the initial split.

Fixes dependabot#10020.
@stefanvanburen stefanvanburen force-pushed the svanburen/fix-go-modules-prerelease branch from 8da649d to ba4cbc3 Compare June 17, 2024 14:28
@kbukum1 kbukum1 merged commit b78e619 into dependabot:main Jun 19, 2024
46 checks passed
@stefanvanburen stefanvanburen deleted the svanburen/fix-go-modules-prerelease branch June 20, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: go:modules Golang modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot selects incorrect prerelease version for Go
3 participants