Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type Dependabot::Bundler::PathGemSpecFinder #10027

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

raj-meka
Copy link
Contributor

@raj-meka raj-meka commented Jun 18, 2024

What are you trying to accomplish?

Sorbet Implementation for Bundler PathGemSpecFInder ruby file.

Anything you want to highlight for special attention from reviewers?

Please pay attention to the fixes in the Bundler PathGemSpecFInder ruby file.

How will you know you've accomplished your goal?

The sorbet rules will fire as needed.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@raj-meka raj-meka requested a review from a team as a code owner June 18, 2024 03:42
@raj-meka raj-meka requested a review from JamieMagee June 18, 2024 03:42
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Jun 18, 2024
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Jun 18, 2024
@raj-meka raj-meka force-pushed the Strict-type-DependabotBundlerPathGemSpecFinder branch from 8fa6b6f to 21d5dc7 Compare June 19, 2024 14:02
@raj-meka raj-meka requested a review from JamieMagee June 19, 2024 14:02
@GarryHurleyJr GarryHurleyJr force-pushed the Strict-type-DependabotBundlerPathGemSpecFinder branch from 711d436 to 15a7856 Compare June 20, 2024 17:46
@raj-meka raj-meka force-pushed the Strict-type-DependabotBundlerPathGemSpecFinder branch from 15a7856 to eda96bd Compare June 24, 2024 18:05
@raj-meka raj-meka merged commit 43c1297 into main Jun 24, 2024
58 checks passed
@raj-meka raj-meka deleted the Strict-type-DependabotBundlerPathGemSpecFinder branch June 24, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants