Return empty string if index-url not provided to AuthedUrlBuilder #10035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
While AuthedUrlBuilder could be provided no index-url, it does not handle this case, making the following line cause an exception:
This can happen, for example, when tools like Dependabot for Azure DevOps do not provide index-url generally, as described in this issue:
tinglesoftware/dependabot-azure-devops#1167
Anything you want to highlight for special attention from reviewers?
Another approach would be to make Dependabot for Azure DevOps provide index-url for Python dependencies in credentials, however this would not fix the general issue of AuthedUrlBuilder not handling a
nil
index-url.How will you know you've accomplished your goal?
tinglesoftware/dependabot-azure-devops#1167 will essentially become irrelevant.
Checklist