Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type Dependabot::Bundler::FileFetcher #10044

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

raj-meka
Copy link
Contributor

@raj-meka raj-meka commented Jun 19, 2024

What are you trying to accomplish?

Sorbet Implementation for Bundler FileFetcher ruby file.

Anything you want to highlight for special attention from reviewers?

Please pay attention to the fixes in the Bundler FileFetcher ruby file.

How will you know you've accomplished your goal?

The sorbet rules will fire as needed.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@raj-meka raj-meka requested a review from a team as a code owner June 19, 2024 16:39
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Jun 19, 2024
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Jun 20, 2024
@JamieMagee JamieMagee force-pushed the Strict-type-DependabotBundlerFileFetcher branch from f7720b7 to c463d93 Compare July 3, 2024 04:04
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes.

@raj-meka raj-meka force-pushed the Strict-type-DependabotBundlerFileFetcher branch from c463d93 to 6ea0efb Compare July 3, 2024 13:34
@raj-meka raj-meka merged commit c9c8023 into main Jul 3, 2024
58 checks passed
@raj-meka raj-meka deleted the Strict-type-DependabotBundlerFileFetcher branch July 3, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants