Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Use scenario-specific fixtures #2741

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Nov 11, 2020

This PR

  • splits fixtures that are currently reused for different scenarios into scenario-specific fixtures

Follows #2682 (comment).

πŸ’β€β™‚οΈ I will pick work on this up later!

@jurre
Copy link
Member

jurre commented Nov 11, 2020

This is an amazing start, thank you @localheinz!

@localheinz
Copy link
Contributor Author

@jurre

I have started a couple of times to reorganize the fixtures to stop reusing them across tests, but I have always come to the point where I feel that the tests fixtures are jus terribly organized, and given up. Adopting project-specific fixtures as for other package managers does not make sense to me either when these projects are then reused across different tests as well.

In my experience, the only thing that would make sense here would be to have a single set of files for every single test scenario.

The downside of this approach is that this will introduce a lot of duplicated files, but the upside is that changing fixtures in one place will not fail tests in unexpected places.

Currently, the fixtures are just terribly organized!

@localheinz localheinz closed this Nov 14, 2020
@localheinz localheinz deleted the feature/fixtures branch November 14, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants