Add rubocop config for each language #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At some point rubocop removed support for finding configs in parent directories and only loads the .rubocop.yml defined in the current folder so we used to run CI lint with `-c ../.rubocop.yml` but this breaks editors (e.g. vscode) support as it needs to run rubocop in the package manager folder.
jurre
approved these changes
Nov 30, 2020
feelepxyz
added a commit
that referenced
this pull request
Mar 8, 2021
v7.6.1 (2021-03-04) https://github.com/npm/cli/releases/tag/v7.6.1 BUG FIXES 3c9a589b0 #2807 npm explain show when an edge is a bundled edge (@kumavis) b33c760ce #2766 unused arguments cleanup (@sandersn) 4a5dd3a5a #2772 fix(npm) pass npm context everywhere (@wraithgar) e69be2ac5 #2789 fix npm prefix on all Windows unix shells (@isaacs) 2d682e4ca #2803 fix(search): don't pass unused args (@wraithgar) b3e7dd19b #2822 fix(diff): set option "where" for pacote (@ruyadorno) 96006640b #2824 fix(repo, auth.sso): don't promisify open-url (@wraithgar) DOCUMENTATION c8b73db82 #2690 fix(docs): update scripts docs (@wraithgar) 5d922394b #2809 update republish timeout after unpublish (@BAJ-) DEPENDENCIES 2d4ae598f @npmcli/arborist@2.2.6
feelepxyz
added a commit
that referenced
this pull request
Mar 8, 2021
v7.6.1 (2021-03-04) https://github.com/npm/cli/releases/tag/v7.6.1 BUG FIXES 3c9a589b0 #2807 npm explain show when an edge is a bundled edge (@kumavis) b33c760ce #2766 unused arguments cleanup (@sandersn) 4a5dd3a5a #2772 fix(npm) pass npm context everywhere (@wraithgar) e69be2ac5 #2789 fix npm prefix on all Windows unix shells (@isaacs) 2d682e4ca #2803 fix(search): don't pass unused args (@wraithgar) b3e7dd19b #2822 fix(diff): set option "where" for pacote (@ruyadorno) 96006640b #2824 fix(repo, auth.sso): don't promisify open-url (@wraithgar) DOCUMENTATION c8b73db82 #2690 fix(docs): update scripts docs (@wraithgar) 5d922394b #2809 update republish timeout after unpublish (@BAJ-) DEPENDENCIES 2d4ae598f @npmcli/arborist@2.2.6
feelepxyz
added a commit
that referenced
this pull request
Mar 8, 2021
v7.6.1 (2021-03-04) https://github.com/npm/cli/releases/tag/v7.6.1 BUG FIXES 3c9a589b0 #2807 npm explain show when an edge is a bundled edge (@kumavis) b33c760ce #2766 unused arguments cleanup (@sandersn) 4a5dd3a5a #2772 fix(npm) pass npm context everywhere (@wraithgar) e69be2ac5 #2789 fix npm prefix on all Windows unix shells (@isaacs) 2d682e4ca #2803 fix(search): don't pass unused args (@wraithgar) b3e7dd19b #2822 fix(diff): set option "where" for pacote (@ruyadorno) 96006640b #2824 fix(repo, auth.sso): don't promisify open-url (@wraithgar) DOCUMENTATION c8b73db82 #2690 fix(docs): update scripts docs (@wraithgar) 5d922394b #2809 update republish timeout after unpublish (@BAJ-) DEPENDENCIES 2d4ae598f @npmcli/arborist@2.2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point rubocop removed support for finding configs in parent
directories and only loads the .rubocop.yml defined in the current
folder so we used to run CI lint with
-c ../.rubocop.ymlbut thisbreaks editors (e.g. vscode) support as it needs to run rubocop in the
package manager folder.