Add error handling for failure while updating Pull request in azure #3493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
reviewed
Apr 14, 2021
jurre
reviewed
Apr 15, 2021
jurre
approved these changes
Apr 15, 2021
feelepxyz
reviewed
Apr 15, 2021
common/lib/dependabot/errors.rb
Outdated
| @@ -71,6 +71,15 @@ def initialize(source, msg = nil) | |||
| end | |||
| end | |||
|
|
|||
| class PullRequestUpdateFailed < DependabotError | |||
There was a problem hiding this comment.
Sorry for the slow review. Do we want to add this as a top-level error? Not sure we want to backport this to the other updaters, for github there are so many different reasons for a PR update failing so will be hard to reuse there. Maybe better to just add it in the Azure class for now?
There was a problem hiding this comment.
Cool makes sense! I'll add this in azure pr updater class
Co-authored-by: Jurre <jurre@github.com>
|
@jurre @feelepxyz can we merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic in the azure PR updater to raise an error of type
Dependabot::PullRequestUpdateFailedwhen the update ref call to update the source branch is unsuccessful. Currently the update_ref API in azure returns a 200 response code even when the update operation is unsuccessful hence need to check the response body to verify if the update operation is successful@feelepxyz @jurre Does this way of error handling makes sense? Apologies for creating a separate PR for this small change