gradle: only commit versions are git sourced #3585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Dependabot::Gradle::FileParser
, there's an assumption that any package that begins withcom.github.*
is backed by a git repository.This has implications in
Dependabot::Gradle::UpdateChecker
, where it means Dependabot will prefer to check the git repository's commit history in place of querying the maven repository for the latest version.This was intended to integrate with https://jitpack.io/ , a service that builds Java artifacts directly from commits. This can be confirmed by inspecting the repository in the test case: https://github.com/heremaps/oksse suggests Jitpack to consume artifacts.
Using the
GitCommitChecker
makes sense for Jitpack:0.9.0
, which is tagged from heremaps/oksse@c92d055This has unintended consequences for the the 36,180 packages on maven central that begin with com.github.*. Or GitHub Packages users like me!
This PR amends the check so that only versions that are already git commits are routed through the git commit checker.