-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create changelog from merge commits #3642
Conversation
👍 This (PR titles) is what I tend to do manually when I'm not familiar enough with a diff to summarize. Aside: https://github.com/atlassian/changesets / https://github.com/changesets/action provides some neat tooling here too, but that's a much bigger leap than "CHANGELOG.md, but easier". Alternatively, what about a process that encourages Meh, that's manual and tedious - this is ✨magic✨ . |
This looks cool! Up for testing it out. Yeah keen to improve the current flow a bit as I frequently reach for the PRs to reach for author/title. |
b81d6ba
to
dfd9539
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dig it!
👍🏻 I like this approach, as _thepwagner notes this is automating what I already do when I don't have context on the change. I think it's a good forcing function to encourage expressive Pull Request naming by authors and their reviewers over time. |
bin/bump-version.rb
Outdated
@@ -7,6 +7,19 @@ | |||
end | |||
component = ARGV[0].to_sym | |||
|
|||
unless `which gh` && $?.success? | |||
puts "Please install the gh cli: brew install gh" | |||
exut 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit typo for exit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
Build the changelog entries from merge commit PR details instead of the individual commits, automating attribution to non-team members and including a link to the PR.
Example: