Terraform: always clone repository contents #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform projects can include local path modules that are currently not fetched in the file fetching step so any lockfile update will fail because these files are missing. The easiest fix seemed to be to always start cloning terraform projects as this is what we want to end up doing for all ecosystems. The file fetcher will still hit the gh api when getting the reo contents but this would require changes in common so keen to make that change separately as it currently works.
feelepxyz
changed the title
feelepxyz
commented
Jun 23, 2021
| @@ -17,3 +17,6 @@ | |||
| require "dependabot/dependency" | |||
| Dependabot::Dependency. | |||
| register_production_check("terraform", ->(_) { true }) | |||
|
|
|||
| require "dependabot/utils" | |||
| Dependabot::Utils.register_always_clone("terraform") | |||
There was a problem hiding this comment.
I'm pretty sure this is all that needs to be done, in addition to the file updater change to call SharedHelpers.in_a_temporary_repo_directory. Tested with a dry-run and looks like the updater checks this flag to turn on cloning.
There was a problem hiding this comment.
Any reason we shouldn't be doing this?
jurre
approved these changes
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform projects can include local path modules that are currently not
fetched in the file fetching step so any lockfile update will fail
because these files are missing.
The easiest fix seemed to be to always start cloning terraform projects
as this is what we want to end up doing for all ecosystems.
The file fetcher will still hit the gh api when getting the repo contents
but this would require changes in common so keen to make that change
separately as it currently works.