Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Forbidden error type to Azure client #4029

Merged
merged 4 commits into from
Jul 12, 2021

Conversation

wolf-cola
Copy link
Contributor

@wolf-cola wolf-cola commented Jul 6, 2021

Adds a Forbidden error type to Dependabot:Clients:Azure to raise when a request returns 403

This fixes an issue where Dependabot:PullRequestCreator:Azure.create returns a 400 status to the caller when the root issue is a 403 being returned by Dependabot:PullRequestCreator:Azure.create_commit (since Azure.create creates both the commit and pull request it only ever returns the response code for the latter).

@wolf-cola wolf-cola requested a review from a team as a code owner July 6, 2021 17:52
@wolf-cola wolf-cola marked this pull request as draft July 7, 2021 00:52
@wolf-cola wolf-cola marked this pull request as ready for review July 7, 2021 06:05
@wolf-cola wolf-cola marked this pull request as draft July 9, 2021 21:44
@wolf-cola wolf-cola marked this pull request as ready for review July 9, 2021 21:49
Copy link
Contributor

@feelepxyz feelepxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍

@feelepxyz feelepxyz merged commit f4a4129 into dependabot:main Jul 12, 2021
@xlgmokha xlgmokha mentioned this pull request Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants