Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Gitlab approvers logic on pr creation #4747

Merged
merged 4 commits into from Mar 21, 2022
Merged

Update Gitlab approvers logic on pr creation #4747

merged 4 commits into from Mar 21, 2022

Conversation

andrcuns
Copy link
Contributor

  • Updates logic for adding approvals according to api changes in gitlab since version 14
  • Add support for adding reviewers for a merge request by passing reviewers key in approvers hash

Fixes: #4385

@andrcuns andrcuns requested a review from a team as a code owner February 16, 2022 16:58
@Nishnha Nishnha added T: feature-improvement Requests to improve existing features V: GitLab Issues relating to GitLab support labels Mar 8, 2022
@jurre jurre merged commit 8e71199 into dependabot:main Mar 21, 2022
@jurre jurre mentioned this pull request Mar 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurre jurre jurre approved these changes

Assignees
No one assigned
Labels
T: feature-improvement Requests to improve existing features V: GitLab Issues relating to GitLab support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding a reviewer to a GitLab merge request is not working
3 participants
@andrcuns @jurre @Nishnha