fix required checks not run during a release #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have "required checks" configured for the CI, and so if the CI never runs then the build will never pass. So this creates a workflow which runs during a release with identical names to the real CI workflow, but doesn't run the real tests. We also thought it would be a good idea to skip the CodeQL step during a release since it probably won't detect any issues. The CodeQL isn't currently required so no codeql-analysis-release.yml required yet!
brrygrdn
approved these changes
May 17, 2022
|
It worked! #5155 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have "required checks" configured for the CI, and so if the CI never runs then the build will never pass. So this creates a workflow which runs during a release with identical names to the real CI workflow, but doesn't run the real tests.
We also thought it would be a good idea to skip the CodeQL step during a release since it probably won't detect any issues. The CodeQL isn't currently required so no codeql-analysis-release.yml required yet!
See #5143