Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regex to support Gitlab subgroups #5297

Merged
merged 1 commit into from
Jul 25, 2022

Conversation

argoyle
Copy link
Contributor

@argoyle argoyle commented Jun 22, 2022

I think this fixes #4106

@argoyle
Copy link
Contributor Author

argoyle commented Jul 17, 2022

Updated regex a bit since a couple of tests failed.

@argoyle
Copy link
Contributor Author

argoyle commented Jul 17, 2022

Rabased a couple of hundred commits from main as well. Previously failing tests runs fine locally at least.

@rbarbey
Copy link

rbarbey commented Jul 19, 2022

Hey there! It would be really cool if someone could approve the workflows to run. Thank you!

@argoyle
Copy link
Contributor Author

argoyle commented Jul 19, 2022

Hmm, the python test-error doesn't seem related to my change, right?

@jurre
Copy link
Member

jurre commented Jul 19, 2022

Hmm, the python test-error doesn't seem related to my change, right?

No, it shouldn't be, I think it'll be fixed by a rebase.

As for the change, have you been able to test this change end-to-end? We don't really have access to a GitLab setup, so testing this is a bit tricky from our end. Thanks for contributing!

@argoyle
Copy link
Contributor Author

argoyle commented Jul 19, 2022

Ok, rebased another 13 commits. I haven't even tried testing this end to end, not even sure how to go about doing that using the dependabot-gitlab service. 🤷🏻‍♂️

@willianpaixao
Copy link

@argoyle @jurre I'm currently facing this issue so if there's a docker image tag I can update my helm chart and test.

@willianpaixao
Copy link

Maybe @andrcuns can also help out testing.

@argoyle
Copy link
Contributor Author

argoyle commented Jul 19, 2022

@willianpaixao I assume you mean a docker image of dependabot-gitlab? The only way to get that would be to first build dependabot-core and include that version somehow in dependabot-gitlab I think.

@jurre
Copy link
Member

jurre commented Jul 19, 2022

Ok, rebased another 13 commits. I haven't even tried testing this end to end, not even sure how to go about doing that using the dependabot-gitlab service. 🤷🏻‍♂️

Sorry, I also don't know how to do that, we don't maintain that service

@andrcuns
Copy link
Contributor

@argoyle @willianpaixao You should be able to test this fix using this image: registry.gitlab.com/dependabot-gitlab/dependabot/dev:chore-test-regex-fix-d3528a54. I just built it using github repo and branch directly rather than gem from rubygems.

@argoyle
Copy link
Contributor Author

argoyle commented Jul 20, 2022

Thanks @andrcuns, trying it out now

@argoyle
Copy link
Contributor Author

argoyle commented Jul 20, 2022

🎉 Works like a charm

@willianpaixao
Copy link

Hey @jurre @argoyle @andrcuns I have updated my instance and can confirm it works like a charm! 🎉

@argoyle
Copy link
Contributor Author

argoyle commented Jul 20, 2022

And now all checks passed as well. 😊

@jurre jurre merged commit 29b973f into dependabot:main Jul 25, 2022
@jurre
Copy link
Member

jurre commented Jul 25, 2022

Thanks!

@argoyle
Copy link
Contributor Author

argoyle commented Jul 25, 2022

Thank you from us Gitlab-users. ❤️

@brrygrdn brrygrdn mentioned this pull request Jul 26, 2022
@argoyle argoyle deleted the gitlab-subgroup-regex branch June 4, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot doesn't work with projects in GitLab subgroups
5 participants