-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: regex to support Gitlab subgroups #5297
Conversation
ede1a8d
to
a83187d
Compare
Updated regex a bit since a couple of tests failed. |
a83187d
to
b3febe6
Compare
Rabased a couple of hundred commits from main as well. Previously failing tests runs fine locally at least. |
Hey there! It would be really cool if someone could approve the workflows to run. Thank you! |
Hmm, the python test-error doesn't seem related to my change, right? |
No, it shouldn't be, I think it'll be fixed by a rebase. As for the change, have you been able to test this change end-to-end? We don't really have access to a GitLab setup, so testing this is a bit tricky from our end. Thanks for contributing! |
b3febe6
to
49d1a13
Compare
Ok, rebased another 13 commits. I haven't even tried testing this end to end, not even sure how to go about doing that using the dependabot-gitlab service. 🤷🏻♂️ |
Maybe @andrcuns can also help out testing. |
@willianpaixao I assume you mean a docker image of dependabot-gitlab? The only way to get that would be to first build dependabot-core and include that version somehow in dependabot-gitlab I think. |
Sorry, I also don't know how to do that, we don't maintain that service |
@argoyle @willianpaixao You should be able to test this fix using this image: |
Thanks @andrcuns, trying it out now |
🎉 Works like a charm |
And now all checks passed as well. 😊 |
Thanks! |
Thank you from us Gitlab-users. ❤️ |
I think this fixes #4106