Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RuboCop Performance #5586

Merged
merged 27 commits into from
Sep 5, 2022
Merged

Add RuboCop Performance #5586

merged 27 commits into from
Sep 5, 2022

Commits on Sep 5, 2022

  1. Add rubocop-performance as development dependency

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7c3cdd2 View commit details
    Browse the repository at this point in the history

  2. Enable Performance department cops 

    Require rubocop-performance in configuration

Disable Performance/OpenStruct

Disable Performance/SelectMap

Disable Performance/ChainArrayAllocation

Disable Style/MultipleComparison
    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1fcd202 View commit details
    Browse the repository at this point in the history

  3. Fix Performance/RedundantEqualityComparisonBlock offenses 

    Disable Performance/RedundantEqualityComparisonBlock in pull_request/labeler.rb
    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c46db82 View commit details
    Browse the repository at this point in the history

  4. Fix Performance/MapCompact offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7d41a04 View commit details
    Browse the repository at this point in the history

  5. Fix Performance/Count offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    c60cca6 View commit details
    Browse the repository at this point in the history

  6. Fix Performance/ReverseFirst offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    55d68bb View commit details
    Browse the repository at this point in the history

  7. Fix Performance/Detect offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3e363c0 View commit details
    Browse the repository at this point in the history

  8. Fix Performance/DoubleStartEndWith offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    cb1a57b View commit details
    Browse the repository at this point in the history

  9. Fix Performance/StringReplacement offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    dcacf4a View commit details
    Browse the repository at this point in the history

  10. Fix Performance/StringInclude offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3459223 View commit details
    Browse the repository at this point in the history

  11. Fix Performance/DeletePrefix offenses 

    Disable false positives for Performance/DeletePrefix
    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    cdec8d7 View commit details
    Browse the repository at this point in the history

  12. Fix Performance/Casecmp offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1ec095d View commit details
    Browse the repository at this point in the history

  13. Fix Performance/Squeeze offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    03f45c7 View commit details
    Browse the repository at this point in the history

  14. Fix Performance/UnfreezeString offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    23fc98f View commit details
    Browse the repository at this point in the history

  15. Fix Performance/RegexpMatch offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    0615cd9 View commit details
    Browse the repository at this point in the history

  16. Fix Style/StringLiterals offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1a1e440 View commit details
    Browse the repository at this point in the history

  17. Fix Layout/MultilineMethodCallIndentation offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    18bdc8a View commit details
    Browse the repository at this point in the history

  18. Fix Layout/DotPosition offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    09762af View commit details
    Browse the repository at this point in the history

  19. Fix Layout/TrailingWhitespace offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    f6a0bd0 View commit details
    Browse the repository at this point in the history

  20. Fix Performance/ConstantRegexp offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    18f5d3c View commit details
    Browse the repository at this point in the history

  21. Fix Performance/CaseWhenSplat offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    55e7561 View commit details
    Browse the repository at this point in the history

  22. Fix Performance/ReverseEach offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    df73a78 View commit details
    Browse the repository at this point in the history

  23. Fix remaining Style, Layout, and Lint offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3c78584 View commit details
    Browse the repository at this point in the history

  24. Fix Performance/MethodObjectAsBlock offenses 

    Disable Performance/MethodObjectAsBlock in mixfile_sanitizer.rb
    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    52f09c8 View commit details
    Browse the repository at this point in the history

  25. Fix Performance/Count offense

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    afc4f3a View commit details
    Browse the repository at this point in the history

  26. Fix Performance/CollectionLiteralInLoop offenses

    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    6bec4c3 View commit details
    Browse the repository at this point in the history

  27. Fix Performance/RedundantBlockCall offenses 

    Fix test failures introduced by &block signature changes
    @mattt
    mattt committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d00b8aa View commit details
    Browse the repository at this point in the history