deploy commits made after approval #5650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold off on approving so I can test this. Also I seem to have broken the workflow. |
|
Great, it looks like it's working now: |
|
The approval trigger worked: https://github.com/dependabot/dependabot-core/runs/8236295929?check_suite_focus=true |
|
Update trigger worked too: https://github.com/dependabot/dependabot-core/runs/8236356928?check_suite_focus=true Only thing left is to test on main 🤞 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A downside to #5640 was commits pushed after approval aren't deployed.
So to fix that, I've restored the pull_request trigger, but use
ghto get the review state. Thus if a commit comes in after approval it will still be able to see if was approved. Commits before an approval should be skipped.