Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #conficting_dependencies with a locking parent dependabot fixture #5672

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

Nishnha
Copy link
Member

@Nishnha Nishnha commented Sep 9, 2022

This PR adds a new test for UpdateChecker#conflicting_dependencies which uses a locking parent fixture so that the vulnerable transtitive dependency can't be upgraded.

I created and published npm-parent-dependency-5 which has only 1 version v1.0.0 and requires exactly npm-intermediate-dependency@0.0.1. In turn, this version of npm-intermediate-dependency requires exactly npm-transitive-dependency@v1.0.0, locking it from upgrading to the non vulnerable v1.0.1.

This test is subltly different from the "with a conflicting dependency and an unsatisfiable vulnerablity" test that already exists because it uses a valid vulnerable version range for npm-transitive-dependency of < 1.0.0 which could be satisfied by upgrading to v1.0.1. Meanwhile, the existing test uses a version range that cannot be satisfied, < 1.0.2, because no such version of npm-transitive-dependency exists.

@Nishnha Nishnha merged commit ce02c34 into main Sep 9, 2022
@Nishnha Nishnha deleted the nishnha/add-conflicting-dependency-test branch September 9, 2022 21:39
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants