-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make script/debug
a simple wrapper over the CLI
#5733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The only thing we lose with this is discoverability. And IMO it should be intuitive for someone to run this with --help
and that should document --debug
... if it's not, we should fix that (but separate to this PR)
I'm a fan of few scripts where possible, so prefer not to have separate run + debug script (esp for only one flag!)
My one question since I've never played with this script yet is where is this --debug
flag even get passed to / kick in? Is there something in the dockerfile that is dropping the dependabot
CLI go
binary into this folder? I checked but didn't see anything... maybe I'm just blind though.
Makes sense 👍 |
@jeffwidman You have to install the CLI manually for now, it's not used anywhere beside the smoke tests where it gets downloaded on-demand each time. |
How about |
I'm up for anything! You can also add an alias in your shell to make it even shorter |
alternatively, given the names of the other scripts in this folder, could do Also, to be clear, these are just suggestions... not something I feel strongly about either way. |
328c42e
to
c40627a
Compare
Renamed to |
I think both abbreviations work and read great 😅. But I'll update it back since I don't think it matters too much! |
|
If you want to use the interactive debug mode, you can still pass `--debug`, but I think this makes it more useful!
c40627a
to
4f41b6a
Compare
I went ahead and merged since this one was green and up to date, that way it's one less PR that we have to play the "rebase" game on. |
Not sure if this makes sense to you, but today I wanted to use a full CLI run, with my development copy of dependabot-core code, but without a debugging shell. And the current
script/debug
script doesn't let you do that.I thought about removing the hardcoded
--debug
flag, and if you want a debugger console, you can pass the--debug
flag explicitly. Of course, that's more typing, so alternatively we could, for example:dep
for the script name.script/debug
and do what I'm doing here in a separate script.Does this make sense?