Fixes for transitive dependency vulnerabilities without a top level dependency update #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not necessary as the dependencies will be removed as part of applying the other updates.
With a dependency chain of A -> B -> C a vulnerability on C could require an update to B but not A. Prior to this change B would have been omitted from the PR messages because only top level depenencies have requirements.
honeyankit
approved these changes
Sep 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a dependency chain of A -> B -> C a vulnerability on C could require an update to B but not A so the resulting update would be for B & C. This fixes a few issues in that scenario.
These aren't things that are easily tested in the updater spec but I'm planning on adding coverage via the end to end tests in the future.