Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PR message for removed dependencies #5770

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Improve PR message for removed dependencies #5770

merged 2 commits into from
Sep 21, 2022

Conversation

mctofu
Copy link
Contributor

@mctofu mctofu commented Sep 21, 2022 •
edited

This builds on the message improvements in #5595 to also support cases where a dependency is removed.

Old

Bumps xmldom and read-excel-file. These dependencies needed to be updated together.
Removes xmldom
Updates read-excel-file from 4.1.0 to 5.4.7

New

Removes xmldom. It's no longer used after updating ancestor dependency read-excel-file. These dependencies need to be updated together.

Removes xmldom

Updates read-excel-file from 4.1.0 to 5.4.7

@mctofu mctofu marked this pull request as ready for review September 21, 2022 18:07
@mctofu mctofu requested a review from a team as a code owner September 21, 2022 18:07
jurre
jurre approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much more clear!

Nishnha
Nishnha approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

I found that I had to open new Dependabot security update PRs to see the updated messaging for transitive dependencies. The @dependabot recreate command didn't update it for some reason.

You might find that's also the case here.

@mctofu mctofu merged commit 491ac52 into main Sep 21, 2022
@mctofu mctofu deleted the mctofu/removed_pr_message branch September 21, 2022 22:10
@pavera pavera mentioned this pull request Oct 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

@jurre jurre jurre approved these changes

@Nishnha Nishnha Nishnha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mctofu @jeffwidman @jurre @Nishnha