Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarn Berry: run git lfs pull before running yarn #5833
Yarn Berry: run git lfs pull before running yarn #5833
Changes from all commits
35ea619
a009d41
7bf4ffc
f4a58c0
1a16579
184a835
b9c3af1
4b567a2
968075e
e2a9631
5876957
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to return the path and carry on for any error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What other options do you have in mind? I’m not sure what meaningful recovery could be done here…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me first better understand, which errors are you anticipating?
Here are the ones I can think of:
Dependabot::SharedHelpers::HelperSubprocessFailed
raised byrun_shell_command
insuper
or hereNoMethodError
if.yarnrc.yml
is empty, in which caseYAML.load_file
will return false, which does not respond tofetch
Psych::ParseError
if the YAML in the.yarnrc.yml
is invalidIf we encounter an exception outside of these, I think we'd want to let it fail? @jurre might know better 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's reasonable to continue without
lfs pull
in those cases rather than fail the update entirely?You do raise a few good error cases (the empty or invalid .yarnrc.yml for example) that we should probably handle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related:
It took a bit to track down why this started failing on
main
since the error gets swallowed... that means users who are hitting this failure scenario won't be told why...