Yarn Berry: Ensure multiple requirements are parsed correctly #5839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
deivid-rodriguez
approved these changes
Oct 6, 2022
jurre
force-pushed
the
jurre/yarn-berry-multiple-reqs
branch
from
f0debcd
to
99f713f
Compare
When the lockfile contains multiple entries for a dependency that are resolved to a single version, the lockfile will contain an entry like so: ``` postcss@npm:^8.4.14, postcss@npm:^8.4.17, postcss@npm:^8.4.4": version: 8.4.17 ``` This resulted in the requirements not matching, which would result in us picking the wrong version for that dependency in some cases. By ensuring we match these correctly, that issue is resolved.
jurre
force-pushed
the
jurre/yarn-berry-multiple-reqs
branch
from
99f713f
to
95f118e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the lockfile contains multiple entries for a dependency that are resolved to a single version, the lockfile will contain an entry like so:
This resulted in the requirements not matching, which would result in us picking the wrong version for that dependency in some cases.
By ensuring we match these correctly, that issue is resolved.