Yarn Berry: Ensure registry config is respected #5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
force-pushed
the
jurre/yarn-berry-registry-finder-support
branch
2 times, most recently
from
f482423
to
f31e883
Compare
jakecoffman
reviewed
Oct 10, 2022
npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/latest_version_finder.rb
Outdated
Show resolved
Hide resolved
jurre
force-pushed
the
jurre/yarn-berry-registry-finder-support
branch
7 times, most recently
from
6e60d0c
to
f65b782
Compare
jakecoffman
approved these changes
Oct 11, 2022
|
+1 Thanks very helpful! How did you figure out the npmAuthIdent? |
pavera
approved these changes
Oct 11, 2022
When a global/scoped registry is configured in the yarnrc, Dependabot should honor this for all requests, also for Yarn Berry, which prior to this change wasn't the case. This ensures we correctly parse it etc.
jurre
force-pushed
the
jurre/yarn-berry-registry-finder-support
branch
from
f65b782
to
88f5ddf
Compare
I don't think it's related? Let's debug your problem in the issue you've opened for it though 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a global/scoped registry is configured in the yarnrc, Dependabot should honor this for all requests, also for Yarn Berry, which prior to this change wasn't the case.
This ensures we correctly parse it etc.