Remove CI hack much less needed now #5906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added this because our CI was pretty heavy and felt unnecessary to run the whole thing every time ruby gems were released. However, things have changed now so I'm not sure this is necessary. Because: * We release ruby gems much less often now. * We now have other changed files filters in place, so that we only run ecosystem specs when files in those ecosystems change. So, now, we would only run common and updater specs when releasing ruby gems. This seems acceptable to me. The reason I'd like to remove this is: * No longer having to keep this matrix duplicated. * Don't get duplicated jobs in the sidebar of [our actions page](https://github.com/dependabot/dependabot-core/actions), which is makes it harder to access the one you actually want (the non dummy one).
jakecoffman
approved these changes
Oct 17, 2022
|
Thanks for having a look @jakecoffman! |
deivid-rodriguez
deleted the
deivid-rodriguez/remove-ci-hack-much-less-needed-now
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this because our CI was pretty heavy and felt unnecessary to
run the whole thing every time ruby gems were released.
However, things have changed now so I'm not sure this is necessary.
Because:
ecosystem specs when files in those ecosystems change.
So, now, we would only run common and updater specs when releasing
ruby gems. This seems acceptable to me.
The reason I'd like to remove this is:
page, which is
makes it harder to access the one you actually want (the non dummy
one).