Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Current User From List of Default Reviewer #5968

Conversation

Kimor-hello
Copy link
Contributor

Creating a pull request on bitbucket automatically fetch all default reviewer and add it to the reviewer list. However if the user logged in to use the dependabot script on bitbucket is one of the default reviewer, the pull request creation will fail.
To avoid this, this fetch the current user uuid and remove it from the default reviewer list if necessary.

@Kimor-hello Kimor-hello requested a review from a team as a code owner October 25, 2022 07:12
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me other than I am unclear why add the .ruby-version file?

To be clear, I have no way to integration test the client, it's very much a "we're happy to sanity check the code, but otherwise up to the community to maintain". Thank you for the unit test, that certainly helps.

common/.ruby-version Outdated Show resolved Hide resolved
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for including the unit test!

@jeffwidman jeffwidman merged commit 6da4ead into dependabot:main Oct 26, 2022
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants