-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Current User From List of Default Reviewer #5968
Remove Current User From List of Default Reviewer #5968
Conversation
…ttps://github.com/Kimor-hello/dependabot-core into bitbucket-remove-current-user-from-default-reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me other than I am unclear why add the .ruby-version
file?
To be clear, I have no way to integration test the client, it's very much a "we're happy to sanity check the code, but otherwise up to the community to maintain". Thank you for the unit test, that certainly helps.
…ttps://github.com/Kimor-hello/dependabot-core into bitbucket-remove-current-user-from-default-reviewer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for including the unit test!
Creating a pull request on bitbucket automatically fetch all default reviewer and add it to the reviewer list. However if the user logged in to use the dependabot script on bitbucket is one of the default reviewer, the pull request creation will fail.
To avoid this, this fetch the current user uuid and remove it from the default reviewer list if necessary.