Support version-update:ignore-{patch,minor,major} in docker ecosystem

[deivid-rodriguez]

I think CI will fail since this required a few changes, but I think the idea is solid. Will explain in more detail later.

Fixes #5758.
Fixes #1971.

[deivid-rodriguez]

Ok, so this is the explanation.

Currently ignore conditions require semver-compatible and rubygems-compatible versions. And some Docker versions are not.

My solution may be a bit heavy-handed. It involves extracting a base Dependabot::Version class all other Version classes inherit from, implement a Dependabot::Version#semver method on it that plays nice with ignore conditions and let specific ecosystems override it as needed.

Not sure what you'll think about it, but it's the approach I liked best from what I tried.

Let me know!

[Nishnha]

I think this is an okay approach, but I can see how it could be considered heavy-handed.

I see this more as preventative maintenance since ecosystems could always extend their semver-compatible version ranges and introduce a bug similar to this Docker ignored version ranges one.

I do have one question around how Docker might handle a version string that does not contain an underscore, but outside of that this LGTM.

[castus]

Hi @deivid-rodriguez , could you tell me, when this PR will be released for all users?

[deivid-rodriguez]

We're planning to do public gem releases soon, but I can't tell you a specific date.

[ronan-mch]

We're planning to do public gem releases soon, but I can't tell you a specific date.

Does this apply to users of the Dependabot app in GitHub? I'm seeing on another thread that some users are getting the PRs that they expect, but I'm not seeing that on my test app. Is that because the change hasn't shipped or because there's something wrong with my setup?

[deivid-rodriguez]

Nope, that only applies to people using dependabot as a library. This PR is already deployed to the Github service. If you're getting something unexpected, feel free to report a new issue!