Metadata fetching: Don't fallback to git if not installed
#6409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Put this up as a draft for feedback because there are two different possible approaches... before merge, will need to remove one of them. |
jeffwidman
force-pushed
the
dont-fallback-when-git-not-installed
branch
2 times, most recently
from
c0df633
to
0750981
Compare
|
Switched to rescuing This is ready for review. I'm not sure:
|
... my guess is most users who use
jeffwidman
force-pushed
the
dont-fallback-when-git-not-installed
branch
from
0750981
to
e7dba12
Compare
deivid-rodriguez
approved these changes
Jul 24, 2023
This git fallback is being hit whenever there's a non-`200` response code. However, if `git` isn't installed, this will result in throwing: ```shell Errno::ENOENT with No such file or directory - git ``` So catch the error and handle it.
jeffwidman
force-pushed
the
dont-fallback-when-git-not-installed
branch
from
e7dba12
to
3ff8f1c
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…ot#6409) This git fallback is being hit whenever there's a non-`200` response code. However, if `git` isn't installed, this will result in throwing: ```shell Errno::ENOENT with No such file or directory - git ``` So catch the error and handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This git fallback is being hit whenever there's a non-
200response code. However, ifgitisn't installed, this will result in throwing:So only fallback to
gitif installed.