Add compatibility with composer v2.4+ #6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Oh perfect timing, I was planning to work on #5720 / #6385 / #6385 (comment) later this week!
I suspect life is simpler if we just keep on the latest composer and don't worry about backwards compatibility for options... I assume most folks run dependabot within the context of our bundled dependabot-core image, so they'll be using whatever version of composer is bundled with that. If you think differently for some reason, please let me know.
For simplicity of working across timezones / PR rebases, does the following sound reasonable?
- Merge this
- Rebase the Dependabot PR to bump
composerto2.5.x - Add a commit remove the optional checks, such that
setAuditis always called. - Merge... so hopefully we'll be back up to
composerlatestby EOD 👍
jeffwidman
reviewed
Jan 23, 2023
| // For all potential options, see UpdateCommand in composer | ||
| $install | ||
| ->setUpdate(true) | ||
| ->setInstall(false) | ||
| ->setDevMode(true) | ||
| ->setUpdateAllowTransitiveDependencies(Request::UPDATE_LISTED_WITH_TRANSITIVE_DEPS) | ||
| ->setDumpAutoloader(false) | ||
| ->setRunScripts(false) | ||
| ->setIgnorePlatformRequirements(false); | ||
| ->setPlatformRequirementFilter(PlatformRequirementFilterFactory::fromBoolOrList(false)); |
There was a problem hiding this comment.
😍 for fixing this, as a non-PHP expert, I would have muddled for a while before realizing it needed another import...
- Use `eventDispatcher::setRunScripts` instead of deprecated `Installer::setRunScripts` - Use `Installer::setPlatformRequirementFilter` instead of deprecated `Installer::setIgnorePlatformRequirements` - Use `setAudit(false)` if Installer has that method
jeffwidman
force-pushed
the
add-compatibility-with-composer-v2.4-v2.5
branch
from
83376ae
to
5b89b08
Compare
That sounds completely reasonable. 👍 |
alcere
pushed a commit
that referenced
this pull request
Feb 20, 2023
When running the dependabot-script with `DEBUG_HELPERS=true` I saw this error: ``` PHP Deprecated: Installer::setIgnorePlatformRequirements is deprecated since Composer 2.2, use setPlatformRequirementFilter instead. in /opt/composer/v2/vendor/composer/composer/src/Composer/Installer.php on line 1289 ``` So this commit resolves the deprecations and also added a forward compatible change to [disable the audit](#6385 (comment)). Applied changes: - Use `eventDispatcher::setRunScripts` instead of [deprecated `Installer::setRunScripts`](https://github.com/composer/composer/blob/2.5.1/src/Composer/Installer.php#L1241) - Use `Installer::setPlatformRequirementFilter` instead of [deprecated `Installer::setIgnorePlatformRequirements`](https://github.com/composer/composer/blob/2.5.1/src/Composer/Installer.php#L1297) - Use `setAudit(false)` if Installer has that method Co-authored-by: Stefan Grootscholten <stefan.grootscholten@tripolis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the dependabot-script with
DEBUG_HELPERS=trueI saw this error:In this PR I work around the deprecations (there was one more, which was not verbose) and also added a forward compatible change to disable the audit.
Applied changes:
eventDispatcher::setRunScriptsinstead of deprecatedInstaller::setRunScriptsInstaller::setPlatformRequirementFilterinstead of deprecatedInstaller::setIgnorePlatformRequirementssetAudit(false)if Installer has that method