Fix build.gradle files missing some updates #6624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
reviewed
Feb 9, 2023
|
|
||
| raise "Expected content to change!" if updated_content == buildfile.content | ||
|
|
||
| updated_file(file: buildfile, content: updated_content) | ||
| end | ||
|
|
||
| def original_buildfile_declaration(dependency, requirement) | ||
| def original_buildfile_declarations(dependency, requirement) | ||
| # This implementation is limited to declarations that appear on a | ||
| # single line. |
There was a problem hiding this comment.
A reminder that we'd benefit greatly from:
jeffwidman
approved these changes
Feb 9, 2023
When multiple configurations include the same dependency, only one would be updated.
jeffwidman
force-pushed
the
deivid-rodriguez/dependabot-core-6598
branch
from
d03794f
to
6517e50
Compare
alcere
pushed a commit
that referenced
this pull request
Feb 20, 2023
Within a single file, when multiple configurations include the same dependency, only one would be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple configurations include the same dependency, only one would be updated.
Fixes #6598.