Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM: handle EBADENGINE better #7194

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

jakecoffman
Copy link
Member

For additional context see #4072 (comment)

When engine-strict is set to true, Dependabot can error if the currently installed version doesn't match the range set in package.json.

This gives the error in the UI more substance to help the customer figure out why it happened and solve the problem if they choose. Also helps clean up our error reporting!

@jakecoffman jakecoffman requested a review from a team as a code owner April 28, 2023 13:57
Copy link
Member

@abdulapopoola abdulapopoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find and fix! Love the fact that we are cleaning up our errors with actionable info for our users!! Thanks.

@jakecoffman jakecoffman merged commit 843e728 into main Apr 28, 2023
@jakecoffman jakecoffman deleted the jakecoffman/handle-ebadengine branch April 28, 2023 15:39
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants