Revert sanitization of package name #7246
Conversation
|
The removed tests still pass after the revert. Of course, because test npm and the removed code is for Yarn. Something got weirdly out of sync here. In any case, just to make sure I migrated the specs to use Yarn, and they still pass. In any case, I think it's best to remove them to avoid any confusion, since there's nothing invalid (I believe) about a package name with spaces? |
|
🤔 Perhaps this was originally intended to sanitize the package name when it was used for the branch name? Agree though that the place to handle that is at the branch name sanitizer, not here... |
|
That's a good point, but yeah if that was needed the place would be wrong. And why only for Yarn? 🤷♂️ |
deivid-rodriguez
force-pushed
the
deivid-rodriguez/revert-package-name-sanitization
branch
from
b7c70df
to
0fbcbb1
Compare
jeffwidman
force-pushed
the
deivid-rodriguez/revert-package-name-sanitization
branch
from
0fbcbb1
to
e024f35
Compare
I think this was a mistake from the beginning. The specs added after reverting the patch still pass without the change, and the commit message reads: "JS: Sanitize spaces in filenames", while there's no filename involved here whatsoever, just the package name. This commit reverts c5b1fe6 and 2864404.
jeffwidman
force-pushed
the
deivid-rodriguez/revert-package-name-sanitization
branch
from
e024f35
to
1ed2478
Compare
|
Checked with Deivid on slack and he thought this was good to go, so going to merge/deploy it. |
I think this was a mistake from the beginning. The specs added after reverting the patch still pass without the change, and the commit message reads: "JS: Sanitize spaces in filenames", while there's no filename involved here whatsoever, just the package name. This commit reverts c5b1fe6 and 2864404.
I think this was a mistake from the beginning. The specs added after reverting the patch still pass without the change, and the commit message reads: "JS: Sanitize spaces in filenames", while there's no filename involved here whatsoever, just the package name.
This commit reverts c5b1fe6 and 2864404.
References: #7245 (comment).