Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove persistent_gems_after_clean workaround #7296

Merged
merged 1 commit into from Jun 20, 2023

Conversation

jurre
Copy link
Member

@jurre jurre commented May 11, 2023

We put this check in place as a workaround for an internal project at GitHub that was using some custom extensions to bundler. This has since been removed, and this check is no longer relevant, so let's clean it up.

@jurre jurre requested a review from a team as a code owner May 11, 2023 13:20
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label May 11, 2023
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the same code is present on Bundler 1 helper and that can go too?

@jurre jurre force-pushed the jurre/rm-persistent-gems-after-clean-hack branch 2 times, most recently from 178d9db to eefe594 Compare May 11, 2023 16:40
@jurre jurre force-pushed the jurre/rm-persistent-gems-after-clean-hack branch from eefe594 to d1bb2ad Compare May 12, 2023 11:54
We put this check in place as a workaround for an internal project at
GitHub that was using some custom extensions to bundler. This has since
been removed, and this check is no longer relevant, so let's clean it
up.
@jurre jurre force-pushed the jurre/rm-persistent-gems-after-clean-hack branch from d1bb2ad to 278fb8c Compare June 20, 2023 10:05
@jurre jurre merged commit 6fbe380 into main Jun 20, 2023
83 checks passed
@jurre jurre deleted the jurre/rm-persistent-gems-after-clean-hack branch June 20, 2023 11:39
jeffwidman pushed a commit that referenced this pull request Aug 8, 2023
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
…t-gems-after-clean-hack

Remove `persistent_gems_after_clean` workaround
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants