Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buid(deps): bump Yarn from 3.5.0 to 3.6.0 #7329

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented May 16, 2023

@yeikel yeikel requested a review from a team as a code owner May 16, 2023 20:10
Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to hold off merging this for a bit more, but going to approve so we know that it's good to go once we're ready

@yeikel yeikel changed the title buid(deps): bump Yarn from 3.5.0 to 3.5.1 buid(deps): bump Yarn from 3.5.0 to 3.6.0 Jun 26, 2023
@yeikel
Copy link
Contributor Author

yeikel commented Jun 26, 2023

We'll need to hold off merging this for a bit more, but going to approve so we know that it's good to go once we're ready

Please note that 3.6.0 is out and I just updated this pull request

Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard to review this upgrades since there's no upstream changelog, but I'd say let's do this and trust our tests. The less unreleased changes we accumulate, the easier will be to figure out regressions.

Also, to be noted that since we use corepack, we're already running Yarn versions higher than 3.5.0 after all, for users that are making that explicit through their package.json file.

@yeikel yeikel force-pushed the patch-3 branch 2 times, most recently from 48be28e to 7f65584 Compare July 2, 2023 00:22
Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in favor of keeping this moving forward for all the reasons Deivid mentioned.

@jeffwidman jeffwidman enabled auto-merge (squash) July 13, 2023 16:01
@jeffwidman jeffwidman merged commit 8784666 into dependabot:main Jul 13, 2023
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants