Look in parent directories for nuget.config files #7342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarolf
force-pushed
the
dev/jmarolf/bugfix/look-for-nugetconfig-in-parent-folder
branch
4 times, most recently
from
89032ec
to
6bc9c17
Compare
|
Thanks! The code change looks good to me and the new functionality makes sense. We'll need to hold off with merging this for a bit as we're prioritizing some stability work internally. I'll update here once we're ready to accept this. |
jurre
approved these changes
Jun 5, 2023
jurre
force-pushed
the
dev/jmarolf/bugfix/look-for-nugetconfig-in-parent-folder
branch
from
6bc9c17
to
6597d50
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
Public pull request is here: dependabot#7342 Related work items: #2064024
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
…ok-for-nugetconfig-in-parent-folder Look in parent directories for nuget.config files
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
Public pull request is here: dependabot#7342 Related work items: #2064024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
technically nuget.config files don't need to be next to project or solution files. Nuget traverses the parent directories as well. This change allows us to look for the nuget.config files in the same way the nuget client does