python: Handle explicit PyPI source in pyproject.toml #7499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
reviewed
Jun 30, 2023
python/spec/dependabot/python/update_checker/index_finder_spec.rb
Outdated
Show resolved
Hide resolved
jurre
approved these changes
Jul 3, 2023
jurre
force-pushed
the
python-handle-pypi-source-without-url
branch
from
97fc090
to
92d6963
Compare
GriceTurrble
reviewed
Jul 3, 2023
GriceTurrble
reviewed
Jul 3, 2023
|
cc @jeffwidman or @pavera as my go-to python people, could you take a quick look at this? |
|
@jurre any ETA on this fix? It's really crippling teams upgraded to latest Poetry... should we downgrade? |
|
I'll try to take a deeper look at this later this week, we're planning to invest some more time into Python and Python package manager work this quarter, as we know we're a little behind on supporting the newest versions. |
python/spec/dependabot/python/update_checker/index_finder_spec.rb
Outdated
Show resolved
Hide resolved
deivid-rodriguez
force-pushed
the
python-handle-pypi-source-without-url
branch
from
3d0ab55
to
da3ec60
Compare
deivid-rodriguez
force-pushed
the
python-handle-pypi-source-without-url
branch
from
da3ec60
to
0349820
Compare
|
Thanks @torarvid and @GriceTurrble for the patience. I amended this PR with Galen's suggestions and a slightly simpler approach, and hope to be deploying it soon! |
|
Thanks, @deivid-rodriguez! I'm very happy to see this fix go in 👍🏼 |
|
Test failures here are unrelated and should be fixed by #7862. |
deivid-rodriguez
force-pushed
the
python-handle-pypi-source-without-url
branch
from
0349820
to
1b5d374
Compare
jurre
force-pushed
the
python-handle-pypi-source-without-url
branch
from
1b5d374
to
1ec2fbe
Compare
jeffwidman
approved these changes
Aug 22, 2023
jeffwidman
force-pushed
the
python-handle-pypi-source-without-url
branch
from
1ec2fbe
to
0e2fe26
Compare
When a github user has poetry >= 1.5.0, they will be nagged by a warning to run `poetry source add pypi`, which will add the following section to the users pyproject.toml: ```toml [[tool.poetry.source]] name = "PyPI" priority = "primary" ``` This causes the problem that the index_finder will fail due to this section missing a url. This commit works around this issue by skip that case, since we will default to the pypi official url anyways in that case. Co-authored-by: Galen Rice <galen.rice@torqata.com>
jeffwidman
force-pushed
the
python-handle-pypi-source-without-url
branch
from
0e2fe26
to
15078eb
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
When a github user has poetry >= 1.5.0, they will be nagged by a warning to run `poetry source add pypi`, which will add the following section to the users pyproject.toml: ```toml [[tool.poetry.source]] name = "PyPI" priority = "primary" ``` This causes the problem that the index_finder will fail due to this section missing a url. This commit works around this issue by skip that case, since we will default to the PyPI official URL anyways in that case. Co-authored-by: Galen Rice <galen.rice@torqata.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7431.
Fixes #7724.
When a github user has poetry >= 1.5.0, they will be nagged by a warning to run
poetry source add pypi, which will add the following section to the users pyproject.toml:This causes the problem outlined in #7431, that the index_finder will fail due to this section missing a
url.This commit works around this issue by explicitly adding a url for the case where the source "name" is equal to "PyPI".