Update the hex.pm/orgs/dependabot token
#7532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous token was tied to a user account of someone who is no longer on the Dependabot team. When I removed that user from the Hex org, this [test started breaking](https://github.com/dependabot/dependabot-core/actions/runs/5487053978/jobs/9997970150?pr=7525). So this updates the token to an organization-based token, which is not tied to any user. This is a read-only token, which has access to _all_ private packages in the https://hex.pm/orgs/dependabot org. This is a security risk if we don't realize this and accidentally upload a private test package to this organization that we don't want to make public, but there's currently no way to prevent that other than using two separate organizations. I filed a feature request upstream: * hexpm/hexpm#1205
jeffwidman
force-pushed
the
update-hex-org-token
branch
from
28f373d
to
28b1e9b
Compare
jeffwidman
changed the title
hex.pm/orgs/dependabot token
jurre
approved these changes
Jul 7, 2023
I considered it, but thought that since this is technically a unit test in open source, my expectation is anyone should be able to run these tests... we generally tell folks "run Since this is really an integration test, do we have a place where we set those up and open source folks don't necessarily expect to be able to run those? Would smoke tests fit under that category? |
|
Happy to migrate this to an actions secret if instead we decide we don't expect it to pass for open source collaborators... |
|
We chatted about this internally a bit more and decided to stop exposing these tokens in plain text: |
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
The previous token was tied to a user account of someone who is no longer on the Dependabot team. When I removed that user from the Hex org, this [test started breaking](https://github.com/dependabot/dependabot-core/actions/runs/5487053978/jobs/9997970150?pr=7525). So this updates the token to an organization-based token, which is not tied to any user. This is a read-only token, which has access to _all_ private packages in the https://hex.pm/orgs/dependabot org. This is a security risk if we don't realize this and accidentally upload a private test package to this organization that we don't want to make public, but there's currently no way to prevent that other than using two separate organizations. I filed a feature request upstream: * hexpm/hexpm#1205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous token was tied to a user account of someone who is no longer on the Dependabot team. When I removed that user from the Hex org, this test started breaking.
So this updates the token to an organization-based token, which is not tied to any user.
This is a read-only token, which has access to all private packages in the https://hex.pm/orgs/dependabot org.
This is a security risk if we don't realize this and accidentally upload a private test package to this organization that we don't want to make public, but there's currently no way to prevent that other than using two separate organizations.
I filed a feature request upstream: