-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track unknown errors #7534
Merged
Merged
Track unknown errors #7534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b7e69cb
to
4013395
Compare
f954f81
to
fc67509
Compare
Nishnha
commented
Sep 5, 2023
jurre
reviewed
Sep 19, 2023
jurre
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me, but I am slightly worried we could be loggin PII when logging the commands we're running natively, so it might be good to have a look at that. Going to approve as to unblock this once we're confident about that, though 👍
cc1eeb8
to
5765ae0
Compare
5765ae0
to
91a24fe
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
* Refactored error handling and metrics in Dependabot to improve debugging and reporting. This includes enhancing the "unknown_error" metric with package manager tags, passing detailed error information to "record_unknown_error," and updating tests and lint issues for better code quality. --------- Co-authored-by: Ankit Honey <honeyankit@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot currently treats
unknown_errors
the same as any other error type.However,
unknown_errors
are a bit of a special case because they are mostly caused by a HelperSubprocessFailure when Dependabot shells out to native package managers. The helper subprocess failures are harder to debug because they can be specific to a dependency set or some combination of a package manager version and project file features.In order to better investigate unknown errors, we should send the error details to the backend service so we can look for trends.
This PR makes a few changes to the way unknown errors are logged:
a. helper subprocess failures
b. file fetcher command errors
c. update files command errors
server_error
, since they are well-knownupdater.unknown_error
metric with tags for the package managerStill needs a feature flag for GHES support and tests for the new endpoint.EDIT: Check has been added in Dependabot-api to to return immediately if in GHES or Proxima environment