Instrument Python version metric #7617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwidman
force-pushed
the
add-python-version-metric
branch
2 times, most recently
from
165ec0b
to
df65fb4
Compare
jeffwidman
added
the
Ecosystems
pavera
reviewed
Jul 24, 2023
pavera
approved these changes
Jul 25, 2023
jeffwidman
commented
Jul 25, 2023
| # ecosystems our goal is to extract the user specified versions, so we'll need to do file parsing... so should | ||
| # we move this `ecosystem_versions` metrics method to run in the file parser for all ecosystems? Downside is if | ||
| # file parsing blows up, this metric isn't emitted, but reality is we have to parse anyway... as we want to know | ||
| # the user-specified range of versions, not the version Dependabot chose to run. |
There was a problem hiding this comment.
I'm planning to have follow-on PR's that move this to the FileParser class, but that refactor will require more work, and want this live now so it starts collecting metrics, so I'm going to merge as-is and then clean it up.
jeffwidman
commented
Jul 25, 2023
| # TODO: alternatively this could use `python_requirement_parser.user_specified_requirements` which | ||
| # returns an array... which we could flip to return a hash of manifest name => version | ||
| # string and then check for min/max versions... today it simply defaults to | ||
| # array.first which seems rather arbitrary. |
There was a problem hiding this comment.
user_specified_requirements is a private method, so the best way to do that is move this to FileParser, but again, we want metrics soon, so ship this first then clean that up.
We want to know what versions of python are required by our users, so this is an initial stab at collecting some data. Ideally we capture the minimum version, the maximum version, and the raw data from each manifest file that allowed us to calculate the min/max... unfortunately this isn't so clean/polished, but we need to start somewhere and even a primitive form of this metric will provide enough information for us to understand the user impact of dropping python 3.6.
jeffwidman
force-pushed
the
add-python-version-metric
branch
from
26cf1dd
to
96306ed
Compare
jeffwidman
force-pushed
the
add-python-version-metric
branch
from
5457b6e
to
5f524ed
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
We want to know what versions of python are required by our users, so this is an initial stab at collecting some data. Ideally we capture the minimum version, the maximum version, and the raw data from each manifest file that allowed us to calculate the min/max... unfortunately this isn't so clean/polished, but we need to start somewhere and even a primitive form of this metric will provide enough information for us to understand the user impact of dropping python 3.6. --------- Co-authored-by: Tom Christensen <pavera@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to know what versions of python are required by our users, so this is an initial stab at collecting some data.
Ideally we capture the minimum version, the maximum version, and the raw data from each manifest file that allowed us to calculate the min/max... this won't be quite so clean/polished, but we need to start somewhere and even a primitive form of this metric will provide enough information for us to understand the user impact of dropping python 3.6.