fix ungrouped PRs being created due to errors during grouped update #7829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
force-pushed
the
jakecoffman/fix-erroneous-individual-prs
branch
2 times, most recently
from
ca65003
to
ee441e4
Compare
|
Fixes a portion of #7830, but there's still some work to be done for semver updates to fully resolve the issue. |
deivid-rodriguez
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where when an error occurs during a grouped update, Dependabot considers the dependency as ungrouped. This is because for semver grouping we need to make external calls to decide if the dependency is in the group. When not using semver groups, we already know the grouping.
Also it was considering dependencies that didn't have updates to be ungrouped as well, and tried to make an individual PR in that case too.