Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Don't depend on flake8 at runtime (#6830)" #7836

Merged
merged 1 commit into from
Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,4 @@ jobs:
- uses: ruby/setup-ruby@v1
with:
bundler-cache: true
- uses: actions/setup-python@v4
with:
python-version-file: .python-version
cache: pip
- run: pip install -r requirements.txt
- run: ./bin/lint
1 change: 0 additions & 1 deletion .python-version

This file was deleted.

2 changes: 0 additions & 2 deletions bin/lint
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,3 @@ shellcheck \
"$@"

bundle exec rubocop

flake8 python/helpers/. --count --exclude=./.*,./python/spec/fixtures --show-source --statistics
1 change: 1 addition & 0 deletions python/helpers/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
pip==23.2.0
pip-tools==7.2.0
flake8==5.0.4
hashin==0.17.0
pipenv==2022.4.8
pipfile==0.0.2
Expand Down
2 changes: 2 additions & 0 deletions python/script/ci-test
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,7 @@

set -e

pyenv exec flake8 helpers/. --count --exclude=./.*,./python/spec/fixtures --show-source --statistics

bundle install
bundle exec parallel_test spec/ -n "$CI_NODE_TOTAL" --only-group "$CI_NODE_INDEX" --group-by filesize --type rspec --verbose
1 change: 0 additions & 1 deletion requirements.txt

This file was deleted.