Fix encoding option value for gitlab commit creation #7850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrcuns
commented
Aug 19, 2023
deivid-rodriguez
approved these changes
Aug 21, 2023
deivid-rodriguez
force-pushed
the
fix-encoding
branch
from
8938afd
to
e05f6e5
Compare
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
Fix encoding option value for gitlab commit creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broken commit creation for gitlab that was introduced by: #7381
The issue here is that gitlab api only supports 2 encoding values,
base64andtext. Current implementation will try to passutf-8as indicated by unit tests which will raise an error like:Server responded with code 400, message: actions[0][encoding] does not have a valid value, actions[1][encoding] does not have a valid value.Gitlab api doc for refernce: https://docs.gitlab.com/ee/api/commits.html#create-a-commit-with-multiple-files-and-actions