raise exceptions when PR creation fails #8013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return if branch_exists?(branch_name) && unmerged_pull_request_exists? | ||
| return if require_up_to_date_base? && !base_commit_is_up_to_date? | ||
| raise "Unmerged PR exists" if branch_exists?(branch_name) && unmerged_pull_request_exists? | ||
| raise "Base commit is not up to date" if require_up_to_date_base? && !base_commit_is_up_to_date? |
There was a problem hiding this comment.
[newbie q] will these errors get surfaced to the user or will they be currently visible in the logs?
There was a problem hiding this comment.
These will be in the logs, but there is another effort to show the errors to the users as well.
mctofu
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes see reports of PRs failing to create, but the logs have no information in them. I suspect part of this is due to these errors that are being swallowed up as expected.
So I've removed that and replaces a few blank
returns withraiseso we can see when those cases are happening.