Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to requirement classes #8039

Closed
wants to merge 1 commit into from
Closed

Add types to requirement classes #8039

wants to merge 1 commit into from

Conversation

JamieMagee
Copy link
Contributor

Part of #7782

I stopped adding safe navigation operators (&.) and type assertions (T.must) and started using the escape hatch (T.unsafe). Mainly because I am unsure what the expected behaviour is supposed to be in. My main goal with this project is to get as much as possible to as high a type checking level as possible. T.unsafe can be dealt with at a later date when attempting to get to strong.

@JamieMagee JamieMagee requested a review from a team as a code owner September 14, 2023 23:36
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: github:actions GitHub Actions L: elm Elm packages L: git:submodules Git submodules L: terraform Terraform packages L: docker Docker containers L: rust:cargo Rust crates via cargo L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python L: swift Swift packages labels Sep 14, 2023
@JamieMagee JamieMagee force-pushed the jamiemagee/requirement-classes branch 2 times, most recently from 2106385 to cb5ad53 Compare September 14, 2023 23:41
@jakecoffman
Copy link
Member

Nice, we just had a bug yesterday that types could have caught: #8037

@JamieMagee JamieMagee closed this Oct 17, 2023
@JamieMagee
Copy link
Contributor Author

Will split this into smaller PRs

@JamieMagee JamieMagee deleted the jamiemagee/requirement-classes branch October 17, 2023 03:12
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
L: dart:pub Dart packages via pub L: docker Docker containers L: elixir:hex Elixir packages via hex L: elm Elm packages L: git:submodules Git submodules L: github:actions GitHub Actions L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamieMagee @jakecoffman