Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when updating sha-pinned images with no "latest" tag #8070

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Sep 19, 2023

If there's no latest tag, we can't update sha pinned images since we don't know which SHA is the latest.

Previously Dependabot would show the error "Pull request already exists for library/alpine-3 with latest version latest" even if that wasn't the case.

updater | 2023/08/29 00:21:53 INFO <job_714994438> Checking if library/alpine-3 latest needs updating
updater | 2023/08/29 00:21:53 INFO <job_714994438> Latest version is latest
  proxy | 2023/08/29 00:21:53 [018] HEAD https://registry.opensource.zalan.do:443/v2/library/alpine-3/manifests/latest
  proxy | 2023/08/29 00:21:53 [018] 200 https://registry.opensource.zalan.do:443/v2/library/alpine-3/manifests/latest
updater | 2023/08/29 00:21:53 INFO <job_714994438> Pull request already exists for library/alpine-3 with latest version latest

Fixes (part of) #7387.

@janschill
Copy link

Ran into this issue as well. Anything stopping this from getting merged?

@abdulapopoola
Copy link
Member

@deivid-rodriguez is this deployable?

@abdulapopoola abdulapopoola merged commit 13e521c into main Feb 15, 2024
55 checks passed
@abdulapopoola abdulapopoola deleted the deivid-rodriguez/fix-docker-crash branch February 15, 2024 19:19
@abdulapopoola
Copy link
Member

@janschill this is now deployed

Copy link

sentry-io bot commented Feb 19, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ RestClient::ServerBrokeConnection: Server broke connection docker/lib/dependabot/docker/update_checker.rb ... View Issue

Did you find this useful? React with a 👍 or 👎

@deivid-rodriguez
Copy link
Contributor Author

Honestly I don't recall, but I believe while a harmless change, it did not fix the original issue reported in #7387, that's why I had not merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: docker Docker containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants