Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pipenv from 2023.8.28 to 2023.11.15 in /python/helpers #8087

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 24, 2023

Bumps pipenv from 2023.8.28 to 2023.9.8.

Release notes

Sourced from pipenv's releases.

Release v2023.9.8

What's Changed

Full Changelog: pypa/pipenv@v2023.9.7...v2023.9.8

Release v2023.9.7

What's Changed

New Contributors

Full Changelog: pypa/pipenv@v2023.9.1...v2023.9.7

Release v2023.9.1

What's Changed

New Contributors

Full Changelog: pypa/pipenv@v2023.8.28...v2023.9.1

Changelog

Sourced from pipenv's changelog.

2023.9.8 (2023-09-08)

Pipenv 2023.9.8 (2023-09-08)

Bug Fixes

  • ignore_compatibility was supposed to default to False (except for hash collection) [#5926](https://github.com/pypa/pipenv/issues/5926) <https://github.com/pypa/pipenv/issues/5926>_

2023.9.7 (2023-09-07)

Pipenv 2023.9.7 (2023-09-07)

Features & Improvements

  • Updates build to use exclusively pyproject.toml

    Modernizes the build process by consolidating all of setuptools metadata within pyproject.toml and removing deprecated setup.cfg and setup.py. [#5837](https://github.com/pypa/pipenv/issues/5837) <https://github.com/pypa/pipenv/issues/5837>_

Bug Fixes

  • Restore the ignore compatibility finder pip patch to resolve issues collecting hashes from google artifact registry (and possibly others). [#5887](https://github.com/pypa/pipenv/issues/5887) <https://github.com/pypa/pipenv/issues/5887>_
  • Handle case better where setup.py name is referencing a variable that is a string while encouraging folks to migrate their projects to pyproject.toml [#5905](https://github.com/pypa/pipenv/issues/5905) <https://github.com/pypa/pipenv/issues/5905>_
  • Better handling of local file install edge cases; handle local file extras. [#5919](https://github.com/pypa/pipenv/issues/5919) <https://github.com/pypa/pipenv/issues/5919>_
  • Include the Pipfile markers in the install phase when using --skip-lock. [#5920](https://github.com/pypa/pipenv/issues/5920) <https://github.com/pypa/pipenv/issues/5920>_
  • Fallback to default vcs ref when no ref is supplied. More proactively determine package name from the pip line where possible, fallback to the existing file scanning logics when unable to determine name. [#5921](https://github.com/pypa/pipenv/issues/5921) <https://github.com/pypa/pipenv/issues/5921>_

2023.9.1 (2023-09-01)

Pipenv 2023.9.1 (2023-09-01)

Features & Improvements

  • Top level Pipfile sys_platform markers should be transitive; adds top level platform_machine entries that are also transitive. Marker entries continue to operate the same as before. #5892

Bug Fixes

  • Apply patch for install_search_all_sources = True functionality. #5895
  • Relative paths improvements for editable installs. #5896
  • Set log level in resolver to WARN when verbose is not passed. #5897

... (truncated)

Commits
  • cdbb2c1 Release v2023.9.8
  • d54f11e Pass editable for vcs when specified (#5928)
  • 9d470b4 ignore_compatibility was supposed to default to False (#5926)
  • 1e07814 Merge branch 'main' of github.com:pypa/pipenv
  • 06151cf man pages wouldn't build which made release difficult
  • 11b50ab Bumped version.
  • 778b8ed Release v2023.9.7
  • 30e0fa7 reference markdown format
  • 4a85f0b Fallback to default vcs ref and determine package name from the pip line wher...
  • 91743a6 Better handling of local file install edge cases; handle local file extras (#...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

NOTE: PR was edited to bump all the way to 2023.11.15.

@dependabot dependabot bot requested a review from a team as a code owner September 24, 2023 16:50
@dependabot dependabot bot added dependencies python Dependabot pull requests that update Python code labels Sep 24, 2023
@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/pip/python/helpers/pipenv-2023.9.8 branch from f5a20bc to ac6fff2 Compare September 26, 2023 13:48
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 8, 2023

A newer version of pipenv exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/pip/python/helpers/pipenv-2023.9.8 branch 3 times, most recently from 7f1ba6b to 9d71c7f Compare November 1, 2023 18:24
@deivid-rodriguez
Copy link
Contributor

Tricky upgrade but this should be now ready!

@deivid-rodriguez
Copy link
Contributor

Not quite passing yet, actually. Some errors are now hidden under --verbose, but even when passing --verbose, they are justified to a fixed width so they get random newline characters that mess up our regexps.

@deivid-rodriguez
Copy link
Contributor

Upstream issue for that change is pypa/pipenv#2791, and I think it was caused by pypa/pipenv#5897.

@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/pip/python/helpers/pipenv-2023.9.8 branch from 9d71c7f to 81a8d9d Compare November 2, 2023 15:26
@honeyankit
Copy link
Contributor

Customer reported an issue AttributeError: 'Null' object has no attribute '_trivia'. Did you mean: 'trivia'?

The actual issue is in the tomlkit library. The fix has been released 20h before in the tomlkit 0.12.3

While upgrading this PR, we need to make sure, we are upgrading the pipenv to a version which will have the tomlkit version 0.12.3 or above. Till now pipenv version 2023.11.14 does not contain the tomlkit version 0.12.3.

@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/pip/python/helpers/pipenv-2023.9.8 branch 3 times, most recently from b2d86b9 to 4526c6e Compare November 22, 2023 12:09
@deivid-rodriguez deivid-rodriguez changed the title Bump pipenv from 2023.8.28 to 2023.9.8 in /python/helpers Bump pipenv from 2023.8.28 to 2023.11.15 in /python/helpers Nov 22, 2023
@deivid-rodriguez
Copy link
Contributor

Ok, finally got this one ready!

And I also created a PR to pipenv to upgrade their tomlkit vendored version at pypa/pipenv#6024.

@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/pip/python/helpers/pipenv-2023.9.8 branch from 4526c6e to ef96109 Compare November 28, 2023 12:08
@@ -71,11 +71,12 @@ def dependency_name

def pipenv_env_variables
Copy link
Member

@jurre jurre Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated but seems like this should be a constant (let's leave as is for now though)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, maybe it took a parameter at some point or something 🤷‍♂️.

deivid-rodriguez and others added 5 commits November 28, 2023 14:01
From 2023.9.1, pipenv uses this by default, so these changes are to get
ready for that. They need a couple of tweaks, namely:

* Slight tweak in the expected output, since "could not be resolved" is
  no longer included in verbose mode.
* Explicitly set a high `COLUMNS` as ENV so that line wrapping does not
  get in the middle of parsing errors.
We now use verbose mode, so no more error masking.
Bumps [pipenv](https://github.com/pypa/pipenv) from 2023.8.28 to 2023.9.8.
- [Release notes](https://github.com/pypa/pipenv/releases)
- [Changelog](https://github.com/pypa/pipenv/blob/main/CHANGELOG.md)
- [Commits](pypa/pipenv@v2023.8.28...v2023.9.8)

---
updated-dependencies:
- dependency-name: pipenv
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Upgrade required the following changes:

* Move GitDependencyReferenceNotFound regexp match to happen earlier so
  that the error does not get miscategorized as a generic resolution
  error.
* Adapt the GitDependenciesNotReachable regexp to match what pipenv now
  runs.

Signed-off-by: dependabot[bot] <support@github.com>
It only requires a small expectation change to catch up a small spacing
change in pip's output.
@deivid-rodriguez deivid-rodriguez force-pushed the dependabot/pip/python/helpers/pipenv-2023.9.8 branch from ef96109 to 8ab2814 Compare November 28, 2023 13:01
@deivid-rodriguez deivid-rodriguez merged commit 61d6cb0 into main Nov 28, 2023
81 checks passed
@deivid-rodriguez deivid-rodriguez deleted the dependabot/pip/python/helpers/pipenv-2023.9.8 branch November 28, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies L: python python Dependabot pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants