Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Grouped Security Updates are rebased correctly #8204

Merged
merged 1 commit into from Oct 18, 2023

Conversation

jurre
Copy link
Member

@jurre jurre commented Oct 16, 2023

Currently, when rebasing a grouped security update, we will default to creating individual PRs for each dependency, since the updater does not know how to refresh grouped updates.

This adds a basic strategy that reuses the refresh behavior for Version Update groups.

@jurre jurre force-pushed the jurre/group-security-refreshes branch 12 times, most recently from e35aa54 to 4c6de2c Compare October 17, 2023 16:54
@jurre jurre marked this pull request as ready for review October 17, 2023 17:03
@jurre jurre requested a review from a team as a code owner October 17, 2023 17:03
Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jurre jurre force-pushed the jurre/group-security-refreshes branch from 4c6de2c to 728e47a Compare October 18, 2023 10:36
Currently, when rebasing a grouped security update, we will default to
creating individual PRs for each dependency, since the updater does not
know how to refresh grouped updates.

This adds a basic strategy that reuses the refresh behavior for Version
Update groups.
@jurre jurre force-pushed the jurre/group-security-refreshes branch from 728e47a to fa16ea5 Compare October 18, 2023 13:49
@jurre jurre merged commit 7b3b791 into main Oct 18, 2023
80 checks passed
@jurre jurre deleted the jurre/group-security-refreshes branch October 18, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants