Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check types in the updater too #8238

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Oct 19, 2023

Running bundle exec srb tc was not checking the types in the updater, so adding --dir updater seems to fix that.

I ran some other commands too and it did .rbi stuff.

@jakecoffman jakecoffman marked this pull request as ready for review October 19, 2023 20:14
@jakecoffman jakecoffman requested a review from a team as a code owner October 19, 2023 20:14
@jakecoffman
Copy link
Member Author

@JamieMagee look ok? It seems to be working!

@jakecoffman jakecoffman force-pushed the jakecoffman/use-types-in-updater branch from 15c39cb to 78701c6 Compare October 19, 2023 20:35
@jakecoffman jakecoffman enabled auto-merge (squash) October 19, 2023 20:36
@jakecoffman jakecoffman merged commit 6f76aee into main Oct 19, 2023
193 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/use-types-in-updater branch October 19, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants