Switch from pipfile to plette lib
#8627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 16, 2023
The main user of `pipfile` is `pipenv`, and _not_ any of the other python package managers. However, `pipfile` library has been pretty much unmaintained, so `pipenv` switched to using `plette` for parsing/validation of `Pipfile`'s: * pypa/pipenv#5310 * pypa/pipenv#5339 So let's switch our usage as well. Today we only use `pipfile` for generating hashes, so this is effectively a silent no-op. However, down the road we could leverage `plette` for `Pipfile` parsing/validation... for example see how it's flagging things here: dependabot#6104 (comment)
jeffwidman
force-pushed
the
switch-from-pipfile-to-plette-lib
branch
from
61ee2b8
to
5ab89f4
Compare
jurre
approved these changes
Mar 22, 2024
pavera
approved these changes
Mar 22, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main user of
pipfileispipenv, and not any of the otherpython package managers.
However,
pipfilelibrary has been pretty much unmaintained, sopipenvswitched to usingplettefor parsing/validation ofPipfile's:So let's switch our usage as well. Today we only use
pipfileforgenerating hashes, so this switch doesn't change any existing behavior. However, down
the road we could leverage
pletteforPipfileparsing/validation... for example see how it's flagging things here:#6104 (comment)
This PR is identical to #7741, except opening from my fork since I'm no longer on the
team I don't have write access to the main repo. See the additional discussion on that PR with one of the maintainers of
plette/pipenv.