Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strong type Dependabot::Version #8727

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Strong type Dependabot::Version #8727

merged 11 commits into from
Jan 11, 2024

Conversation

JamieMagee
Copy link
Contributor

No description provided.

@JamieMagee JamieMagee requested a review from a team as a code owner January 7, 2024 05:05
@github-actions github-actions bot added L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: terraform Terraform packages L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: dart:pub Dart packages via pub L: javascript L: python labels Jan 7, 2024
@JamieMagee JamieMagee force-pushed the jamiemagee/strong-type-version branch 10 times, most recently from f96dfbd to ef5f3e1 Compare January 7, 2024 22:29
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: docker Docker containers labels Jan 7, 2024
@JamieMagee JamieMagee force-pushed the jamiemagee/strong-type-version branch from ef5f3e1 to e7d9d45 Compare January 7, 2024 22:38
JamieMagee
JamieMagee commented Jan 7, 2024
View reviewed changes
Gemfile Show resolved Hide resolved
@JamieMagee JamieMagee force-pushed the jamiemagee/strong-type-version branch from e7d9d45 to a4a0ad9 Compare January 7, 2024 22:53
@JamieMagee JamieMagee added the sorbet 馃崷 Relates to Sorbet types label Jan 8, 2024
bdragon
bdragon reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@bdragon bdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @JamieMagee! Thanks for annotating the diff with comments 馃檪

LGTM. I just had a question about some T.nilables.

common/lib/dependabot/version.rb Show resolved Hide resolved
npm_and_yarn/lib/dependabot/npm_and_yarn/version.rb Show resolved Hide resolved
@bdragon bdragon merged commit 8495dda into main Jan 11, 2024
116 checks passed
@bdragon bdragon deleted the jamiemagee/strong-type-version branch January 11, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdragon bdragon bdragon approved these changes

@abdulapopoola abdulapopoola abdulapopoola approved these changes

@jakecoffman jakecoffman Awaiting requested review from jakecoffman

Assignees
No one assigned
Labels
L: dart:pub Dart packages via pub L: docker Docker containers L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: rust:cargo Rust crates via cargo L: terraform Terraform packages sorbet 馃崷 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JamieMagee @bdragon @abdulapopoola